Github user tomatophantastico commented on the issue: https://github.com/apache/metamodel/pull/148 Imho, would not refer to utility classs in general as an anti-pattern, you really have to look at it use-case dependent. In this case however, i agree that Metamodelhelper should be replaced. MetamodelHelper appears to do two things: (a) Execute some relation operation on the QueryPostprocessDataContext (order/group/join/...) (b) Deal with the usage of array/List/Iterable in apis I suggest for clearing things up, i move (a) first in a separate static class. From there on more profound ways for executing those operations can be defined. For dealing with (b): Some of them are not used in MM anyway, so they might be as well deleted in MM 6.x.x, may deprecate them in MM 5.x.x? For the other, i would really prefer to clean up the api and switch to Collection/Lists/Sets and Streams instead of arrays and iterables instead of those conversion/filtering methods. This is also rather big, so MM 6.x.x
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---