Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/148#discussion_r129737407
--- Diff: core/src/test/java/org/apache/metamodel/MetaModelHelperTest.java
---
@@ -115,21 +115,16 @@ public void testRightJoin() throws Exception {
public void testSimpleCarthesianProduct() throws Exception {
DataSet dataSet =
MetaModelHelper.getCarthesianProduct(createDataSet1(), createDataSet2());
-
+ List<String> results = new ArrayList<String>();
+
+ while(dataSet.next()){
+ results.add(dataSet.getRow().toString());
+ }
assertEquals(2, dataSet.getSelectItems().length);
- assertTrue(dataSet.next());
- assertEquals("Row[values=[f, b]]", dataSet.getRow().toString());
- assertTrue(dataSet.next());
- assertEquals("Row[values=[f, a]]", dataSet.getRow().toString());
- assertTrue(dataSet.next());
- assertTrue(dataSet.next());
- assertTrue(dataSet.next());
- assertTrue(dataSet.next());
- assertTrue(dataSet.next());
- assertTrue(dataSet.next());
- assertTrue(dataSet.next());
- assertEquals("Row[values=[o, r]]", dataSet.getRow().toString());
- assertFalse(dataSet.next());
+ assertEquals(9, results.size());
+ assertTrue(results.contains("Row[values=[f, b]]"));
+ assertTrue(results.contains("Row[values=[f, a]]"));
+ assertTrue(results.contains("Row[values=[o, r]]"));
--- End diff --
Now that we're not asserting on order anymore, we should probably assert on
the existance of all 9 records. Otherwise we've somehow easened the assertion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
