Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/153#discussion_r130068661
  
    --- Diff: core/src/main/java/org/apache/metamodel/convert/Converters.java 
---
    @@ -188,7 +191,7 @@ private static void 
autoDetectConvertersInternally(DataContext dataContext, Tabl
                 detectors.put(column, new ColumnTypeDetector());
             }
     
    -        Query query = 
dataContext.query().from(table).select(columns).toQuery();
    +        Query query = 
dataContext.query().from(table).select(columns.toArray(new 
Column[columns.size()])).toQuery();
    --- End diff --
    
    Same extra toArray here (just marking them in case I'm right that we can 
avoid them).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to