Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130093372
--- Diff: core/src/main/java/org/apache/metamodel/CompositeDataContext.java
---
@@ -190,9 +183,7 @@ public Schema getSchemaByNameInternal(String name)
throws MetaModelException {
}
}
}
- String[] result = set.toArray(new String[set.size()]);
- Arrays.sort(result);
- return result;
+ return new ArrayList<>(set);
--- End diff --
Ah, missed that. Perfect!
Not sure about List vs. Collection. I think I personally prefer List to
avoid wrapping it before working with it, but it's not a huge deal either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
