Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148127042
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -235,38 +240,28 @@ private boolean isSimpleSelect(SelectClause clause) {
}
/**
- * Executes a simple count query, if possible. This method is provided
to
- * allow subclasses to optimize count queries since they are quite
common
- * and often a datastore can retrieve the count using some specialized
means
- * which is much more performant than counting all records manually.
+ * Executes a simple count query, if possible. This method is provided
to allow subclasses to optimize count queries
+ * since they are quite common and often a datastore can retrieve the
count using some specialized means which is
+ * much more performant than counting all records manually.
*
- * @param table
- * the table on which the count is requested.
- * @param whereItems
- * a (sometimes empty) list of WHERE items.
- * @param functionApproximationAllowed
- * whether approximation is allowed or not.
+ * @param table the table on which the count is requested.
+ * @param whereItems a (sometimes empty) list of WHERE items.
+ * @param functionApproximationAllowed whether approximation is
allowed or not.
* @return the count of the particular table, or null if not available.
*/
protected Number executeCountQuery(Table table, List<FilterItem>
whereItems, boolean functionApproximationAllowed) {
return null;
}
/**
- * Executes a query which obtains a row by primary key (as defined by
- * {@link Column#isPrimaryKey()}). This method is provided to allow
- * subclasses to optimize lookup queries since they are quite common
and
- * often a datastore can retrieve the row using some specialized means
which
- * is much more performant than scanning all records manually.
+ * Executes a query which obtains a row by primary key (as defined by
{@link Column#isPrimaryKey()}). This method is
+ * provided to allow subclasses to optimize lookup queries since they
are quite common and often a datastore can
+ * retrieve the row using some specialized means which is much more
performant than scanning all records manually.
*
- * @param table
- * the table on which the lookup is requested.
- * @param selectItems
- * the items to select from the lookup query.
- * @param primaryKeyColumn
- * the column that is the primary key
- * @param keyValue
- * the primary key value that is specified in the lookup
query.
+ * @param table the table on which the lookup is requested.
+ * @param selectItems the items to select from the lookup query.
+ * @param primaryKeyColumn the column that is the primary key
+ * @param keyValue the primary key value that is specified in the
lookup query.
--- End diff --
Unrelated change.
---
