Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148174162
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -63,24 +64,29 @@
import org.slf4j.LoggerFactory;
/**
- * Abstract DataContext for data sources that do not support SQL queries
- * natively.
+ * Abstract DataContext for data sources that do not support SQL queries
natively.
*
- * Instead this superclass only requires that a subclass can materialize a
- * single table at a time. Then the query will be executed by post
processing
- * the datasets client-side.
+ * Instead this superclass only requires that a subclass can materialize a
single table at a time. Then the query will
+ * be executed by post processing the datasets client-side.
*/
public abstract class QueryPostprocessDataContext extends
AbstractDataContext implements HasReadTypeConverters {
private static final Logger logger =
LoggerFactory.getLogger(QueryPostprocessDataContext.class);
+ public static final String SYSTEM_PROPERTY_CREATE_DEFAULT_TABLE_ALIAS
= "metamodel.alias.default.table";
public static final String INFORMATION_SCHEMA_NAME =
"information_schema";
- private final Map<Column, TypeConverter<?, ?>> _converters;
+ private final Map<Column, TypeConverter<?, ?>> converters;
--- End diff --
I did it for consistency sake actually. Since I introduced a new field
(without the underscore, which I know you don't like) I felt like renaming the
other fields in the class to also not have underscores would be appropriate.
---
