[GitHub] metamodel pull request #165: METAMODEL-1165: Add alias default table

[LosD]

Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/165#discussion_r148367081
  
    --- Diff: 
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
    @@ -458,15 +459,18 @@ protected String getDefaultSchemaName() throws 
MetaModelException {
         @Override
         protected final Schema getSchemaByNameInternal(final String name) 
throws MetaModelException {
             final String mainSchemaName = getMainSchemaName();
    -        if (name == null) {
    -            if (mainSchemaName == null) {
    -                return getMainSchema();
    -            }
    +        if (name == null && mainSchemaName != null) {
                 return null;
             }
     
    -        if (name.equalsIgnoreCase(mainSchemaName)) {
    -            return getMainSchema();
    +        if (name == null || name.equalsIgnoreCase(mainSchemaName)) {
    +            final Schema mainSchema = getMainSchema();
    +            final boolean createAliasTable = singleTableDatastore
    +                    && 
Boolean.parseBoolean(System.getProperty(SYSTEM_PROPERTY_CREATE_DEFAULT_TABLE_ALIAS,
 "true"));
    --- End diff --
    
    Ah, there's my flag! :)


---