Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190898432
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.metamodel.neo4j.utils;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+
+import org.apache.metamodel.schema.ColumnType;
+import org.json.JSONArray;
+import org.json.JSONException;
+import org.json.JSONObject;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ColumnTypeResolver {
+ private static final Logger logger =
LoggerFactory.getLogger(ColumnTypeResolver.class);
+ private final JSONObject _jsonObject;
+ private final List<String> _columnNames = new ArrayList<>();
+ private final List<ColumnType> _columnTypes = new ArrayList<>();
+
+ public ColumnTypeResolver(final JSONObject jsonObject, final String[]
columnNamesArray) {
+ _jsonObject = jsonObject;
+ _columnNames.addAll(Arrays.asList(columnNamesArray));
+ }
+
+ public ColumnType[] getColumnTypes() {
+ try {
+ fillColumnTypesFromMetadata();
+ fillColumnTypesFromData();
+ } catch (final JSONException e) {
+ // ignore missing data
+ }
+
+ fillColumnTypesFromRemainingColumns();
+ return _columnTypes.toArray(new ColumnType[_columnTypes.size()]);
+ }
+
+ private void fillColumnTypesFromData() throws JSONException {
+ final String dataKey = "data";
+
+ if (_jsonObject.has(dataKey)) {
+ final JSONObject data = _jsonObject.getJSONObject(dataKey);
+ final Iterator<?> keysIterator = data.keys();
+
+ while (keysIterator.hasNext()) {
+ final String key = (String) keysIterator.next();
+ final ColumnType type = getTypeFromValue(data, key);
+ _columnTypes.add(type);
+ removeIfAvailable(_columnNames, key);
+ }
+ }
+ }
+
+ private void fillColumnTypesFromMetadata() throws JSONException {
+ final String metadataKey = "metadata";
+
+ if (_jsonObject.has(metadataKey)) {
+ final JSONObject metadata =
_jsonObject.getJSONObject(metadataKey);
+
+ if (metadata.has("id")) {
--- End diff --
On closer inspection, I see that "_id" is also a neo4j name. I thought it
was OUR name for it. In this case my suggested name would be something like
`NEO4J_KEY_ID` or something.
---
