Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190878656
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.metamodel.neo4j.utils;
--- End diff --
If you move this class from the `org.apache.metamodel.neo4j.utils` package
to the `org.apache.metamodel.neo4j` package, you can make its visibility
`package protected` instead of `public`, that way it is not right away
implicitly part of the MetaModel api. And we are not using it elsewhere anyway.
From my point of view it's best to keep visibility of classes and methods as
hidden as possible, we can always make them more visible later. It's however
not really possible the other way around. Once some class or method is public,
it's implicitly part of the api and it's hard to reduce its visibility later on.
---
