Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r194912353
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java ---
@@ -242,17 +240,18 @@ protected DataSet materializeMainSchemaTable(Table
table, List<Column> columns,
}
private void setMaxRows(Scan scan, int maxRows) {
- try {
- // in old versions of the HBase API, the 'setMaxResultSize'
method
- // is not available
- Method method = scan.getClass().getMethod("setMaxResultSize",
long.class);
- method.invoke(scan, (long) maxRows);
--- End diff --
Is using `Scan.setMaxResultSize(...)` still not the recommended approach to
setting max rows? If so, we should keep this approach. I think the PageFilter
is considerably slower.
---
