Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/182#discussion_r195406132
  
    --- Diff: 
hbase/src/main/java/org/apache/metamodel/hbase/HBaseFamilyMap.java ---
    @@ -106,9 +105,9 @@ public String toString() {
                 if (sb.length() > 1) {
                     sb.append(',');
                 }
    -            sb.append(Arrays.toString(entry.getKey()));
    +            sb.append(new String(entry.getKey()));
                 sb.append('=');
    -            sb.append(Arrays.toString(entry.getValue()));
    +            sb.append(new String(entry.getValue()));
    --- End diff --
    
    I believe that there are byte combinations that are simply invalid. So I 
suspect it could throw exceptions in certain cases. I'm not an expert on this 
however. Anyone else who has certainty?


---

Reply via email to