Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195639023
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseFamilyMap.java ---
@@ -106,9 +105,9 @@ public String toString() {
if (sb.length() > 1) {
sb.append(',');
}
- sb.append(Arrays.toString(entry.getKey()));
+ sb.append(new String(entry.getKey()));
sb.append('=');
- sb.append(Arrays.toString(entry.getValue()));
+ sb.append(new String(entry.getValue()));
--- End diff --
The behavior of this String constructor when the given bytes are not valid
in the default charset is unspecified. There is another String constructor
which also takes a Charset as an arguments, that method always replaces
malformed-input and unmappable-character sequences with the charset's default
replacement string. So maybe we should use that instead.
---
