kaspersorensen commented on issue #229: Upgrade to Elasticsearch 7.3.1 URL: https://github.com/apache/metamodel/pull/229#issuecomment-534598512 I haven't worked with ES 7 myself so my review is going to be superficial. To answer this question: ``` The ElasticSeachRestUpdateCallback#execute(ActionRequest) method is public, but I would like to make it package private, because it contains an Elasticsearch internal class in its method signature and is only meant to be used internally by other classes in the same package. Is this something I can just change or do I have to do some evil trickery? ``` I would say that you can just make it package private. I don't think we should expose this sort of stuff as an API.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
