arjansh commented on issue #230: dev/add datatypes to excel columns URL: https://github.com/apache/metamodel/pull/230#issuecomment-535839583 > > > > I'm not sure how you mean that this is general, because, yes it is general because all other data stores which support data types already have their own mechanism for detecting column types, but they're all implemented in different manners, because each data store provides a different manner to get the data types. For all these data stores it's default behavior to determine the column types, so why not for Excel too? > > Maybe just some "column type detector" reusable class that you could use as a sort of builder to add data type observations to. Basically just components that we could derive a general pattern from. And potentially have the `1000` constant in here incapsulated (and eventually made parameterized) from etc. I see what you mean now. I think the code here can be organized in a manner so that the column type detection is implemented on a separate class. I personally don't think it should be generalized right away in the context of this PR, but more likely in a separate PR, because I'm afraid otherwise the scope of this PR will become a bit too broad.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
