arjansh commented on issue #230: dev/add datatypes to excel columns URL: https://github.com/apache/metamodel/pull/230#issuecomment-544478661 @SociopathicPixel Can you also add a unit test for an .xlsx Excel file, because MetaModel uses the `XlsxSpreadsheetReaderDelegate` to read these Excel files (see line 192 in `ExcelDataContext`), so you may need to build in a check which ensure that in case `detectColumnTypes` is set to true on the `ExcelConfiguration`, the `DefaultSpreadsheetReaderDelegate` is always used for reading the Excel file.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
