kaspersorensen commented on issue #230: dev/add datatypes to excel columns URL: https://github.com/apache/metamodel/pull/230#issuecomment-535910559 > I see what you mean now. I think the code here can be organized in a manner so that the column type detection is implemented on a separate class. I personally don't think it should be generalized right away in the context of this PR, but more likely in a separate PR, because I'm afraid otherwise the scope of this PR will become a bit too broad. Yes that's a fine approach.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
