kaspersorensen commented on issue #230: dev/add datatypes to excel columns URL: https://github.com/apache/metamodel/pull/230#issuecomment-536320575 > Maybe we can take a percentage of the file row count? Like check 10% with a max cap of 1000 rows. I don't think it's a case where _we_ can set a default that our users will be happy with. I think 1000 is an OK default for _when the feature is enabled_. I think you should add the number into `ExcelConfiguration` along with a boolean that enables/disables the feature. And the default should be to have it OFF so that we retain backwards compatibility.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
