LosD commented on a change in pull request #229: Upgrade to Elasticsearch 7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r334341141
##########
File path:
elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java
##########
@@ -267,6 +264,10 @@ public static ColumnType
getColumnTypeFromElasticSearchType(final String metaDat
}
public static Row createRow(final Map<String, Object> sourceMap, final
String documentId, final DataSetHeader header) {
+ if (sourceMap == null) {
+ return null;
Review comment:
While the reasoning is good, it doesn't really change the worry: This breaks
the API (as I read it), so at the very least it should be considered if it
requires a major release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
