LosD commented on a change in pull request #229: Upgrade to Elasticsearch 7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r338757768
##########
File path:
elasticsearch/native/src/main/java/org/apache/metamodel/elasticsearch/nativeclient/ElasticSearchDataContextFactory.java
##########
@@ -131,10 +135,16 @@ public DataContext create(DataContextProperties
properties, ResourceFactoryRegis
}
private Client createTransportClient(DataContextProperties properties) {
- final Settings settings = Settings.builder().put().put("name",
"MetaModel").put("cluster.name", getCluster(properties)).build();
+ final Settings settings = Settings
+ .builder()
+ .put("name", "MetaModel")
Review comment:
Is the name anything but a label? If it is, it probably needs to be
configurable. Maybe it should be anyway, since MetaModel is just a library for
the actual client. If anyone is interested in a label for their client (e.g.
for logging purposes, connection lists, branding, whatever), I guess we should
let them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
