kaspersorensen commented on a change in pull request #234: MM-82 Detect Column
Types
URL: https://github.com/apache/metamodel/pull/234#discussion_r354148535
##########
File path:
excel/src/main/java/org/apache/metamodel/excel/ExcelConfiguration.java
##########
@@ -102,17 +115,39 @@ public boolean isSkipEmptyColumns() {
return skipEmptyColumns;
}
+ /**
+ * Defines if columns in the excel spreadsheet should be validated on
datatypes while
Review comment:
Instead of "validated" we should probably write "detected". And we should
also say what happens when this is `false` - then all columns will be of STRING
type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
