GerardDellemann commented on issue #234: MM-82 Detect Column Types URL: https://github.com/apache/metamodel/pull/234#issuecomment-562025565 > > > Really appreciate the backwards-compatible approach used here, and the fact that all existing tests are unaltered. My only nitpick is that there are some indentation differences in some of the files. For example `ExcelConfiguration`. But it does also look like the source files have inconsistent indentation so I can live with it, just a note for us that it looks like we need to reformat some files. Yeah, I didn't apply any formatting on purpose, because then I usually have to undo a lot of changes it makes on code that I did not tough. I can try to apply that now. I also think that this project's code in general really needs refactoring, because the current is hard to understand and messy right now. That should probably be done in another PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
