arjansh commented on a change in pull request #234: MM-82 Detect Column Types
URL: https://github.com/apache/metamodel/pull/234#discussion_r354716598
##########
File path: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java
##########
@@ -253,8 +318,9 @@ private static String getFormulaCellValue(Workbook wb,
Cell cell) {
// evaluate cell first, if possible
try {
if (logger.isInfoEnabled()) {
- logger.info("cell({},{}) is a formula. Attempting to evaluate:
{}",
- new Object[] { cell.getRowIndex(),
cell.getColumnIndex(), cell.getCellFormula() });
+ logger
Review comment:
I think I like the old implementation better, I'm not really a fan of the
`getCellCoordinates`, because that results in two String being instantiated
each time you log a message, instead of just one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
