arjansh commented on a change in pull request #234: MM-82 Detect Column Types
URL: https://github.com/apache/metamodel/pull/234#discussion_r355408277
##########
File path: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java
##########
@@ -195,34 +192,35 @@ public static String getCellValue(Workbook wb, Cell
cell) {
FormulaError formulaError = FormulaError.forInt(errorCode);
errorResult = formulaError.getString();
} catch (RuntimeException e) {
- logger.debug("Getting error code for {} failed!: {}",
cellCoordinate, e.getMessage());
+ logger
+ .debug("Getting error code for ({},{}) failed!: {}",
cell.getRowIndex(), cell.getColumnIndex(),
+ e.getMessage());
if (cell instanceof XSSFCell) {
// hack to get error string, which is available
String value = ((XSSFCell) cell).getErrorCellString();
errorResult = value;
} else {
- logger.error("Couldn't handle unexpected error scenario in
cell: " + cellCoordinate, e);
+ logger
+ .error("Couldn't handle unexpected error scenario
in cell: (" + cell.getRowIndex() + ","
Review comment:
I wouldn't log this on error level, but on warning level, and since we're
throwing the exception, I wouldn't log the complete exception (only the
message). If you do that, you can also you the string format for logging,
instead of appending a String together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
