GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/622
METRON-1005 Create Decodable Row Key for Profiler
To be able to answer the types of questions that I outlined in
[METRON-450](https://issues.apache.org/jira/browse/METRON-450), we need a row
key that is decodable. Right now there is no logic to decode a row key, nor is
the existing row key easily decodable.
Once the row keys can be decoded, you could scan all of the row keys in the
Profiler's HBase table, decode each of them and extract things like, the names
of all your profiles, the names of entities within a profile, the period
duration of a given profile.
- [ ] Do not merge. Opening this PR for review and feedback. I still need
to run this through manual testing.
- [ ] **WARNING**: This change is NOT backwards compatible. The row key
format has changed. All data written with the legacy row key cannot be read by
the new code in this PR. Should I make this backwards compatible? I could
make these changes live in a new `RowKeyBuilder` implementation, which would
allow for backwards compatibility.
## Pull Request Checklist
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1005
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/622.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #622
----
commit edd7fa6946b4bcb5975c8497ab5550201718e426
Author: Nick Allen <[email protected]>
Date: 2017-06-22T21:45:40Z
METRON-1005 Create Decodable Row Key for Profiler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
