Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/622#discussion_r127327990
--- Diff:
metron-analytics/metron-profiler/src/main/flux/profiler/remote.yaml ---
@@ -29,7 +29,7 @@ components:
- name: "saltDivisor"
--- End diff --
I chose to require a flux file change here because this is not something
that any old user should just change. This is only configurable to allow for
backwards compatibility.
In addition, the IoC-like functionality that Flux provides makes it easier
to set whatever configuration values are needed by a `RowKeyBuilder` (like salt
divisor) without polluting the `RowKeyBuilder` interface.
There is no such convenient IoC-like functionality when trying to
instantiate the `RowKeyBuilder` from the client-side in `GetProfile`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
