Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
### Code tree differences in bundles-lib vs nifi-nar-utils
Thanks for the analysis, this will help me a lot.
### Bundle Null Dependency question
> So, since everything in nifi is a bundle, they allow you to pull in at
most one other bundle into your classloader. The way they use it is to have a
bundle of common code, re-used and pulled into other bundles when they are
loaded. Like, hadoop common get's pulled into the hadoop processors and the
hadoop controllers which are separate bundles
My question was, since it throws an exception if no Bundle dependency is
stated, if I have a Bundle that is _not_ actually dependent on any other
bundles, what should I declare it is dependent on? This info should be added
to the README after the current paragraph about Bundle dependencies.
### Ambiguous usage of "type"
>> I'm confused. Is this ("type") the maven artifact classifier, or the
archive file extension?
> I did not modify that, it does not have to do with the archive file
extension
Agree you didn't modify it in BundleMojo, but in
[BundleMojo.java:L685](https://github.com/ottobackwards/metron/blob/METRON-777/bundles-maven-plugin/src/main/java/org/apache/metron/maven/plugins/bundles/BundleMojo.java#L685)
we have 'type' being used as a file extension:
`return new File(basedir, finalName + classifier + "." + type );`
And you added it to
[BundleProvidedDependenciesMojo:L82-L89](https://github.com/ottobackwards/metron/blob/METRON-777/bundles-maven-plugin/src/main/java/org/apache/metron/maven/plugins/bundles/BundleProvidedDependenciesMojo.java#L82-L89),
where it is documented as:
```
* The type we are using for dependencies, should be bundle, but may
* be changed in the configuration if the plugin is producing
* other archive extensions...
```
which sure sounds like a file extension?
So, the above questions are really for information because I find the code
confusing. I think the answer is that the code (which you didn't write) simply
does confuse, or combine, the two usages of "type" as both classifier
(sometimes) and file extension (other times). Which means my suggestion of
using either packageClassifier or packageExtension would be inappropriate.
May I suggest using "packageType" instead? No problem in
BundleProvidedDependenciesMojo, where you introduced it, and in BundleMojo it
is no larger than other mods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
