Github user JonZeolla commented on the issue:

    https://github.com/apache/metron/pull/692
  
    Also, I did notice a couple of things when poking around that probably fit 
best into some new JIRAs that I at least wanted to mention here:
    * It's somewhat unintuitive that we count [starting at zero for 
MONTH()](https://github.com/apache/metron/tree/master/metron-stellar/stellar-common#month),
 unlike WEEK_OF_MONTH, WEEK_OF_YEAR, DAY_OF_MONTH, and DAY_OF_WEEK.
    * We don't comply with [ISO 
8601](https://en.wikipedia.org/wiki/ISO_8601#Week_dates) regarding the first 
day of the week (We use Sunday, ISO says Monday)
    
    ```
    [Stellar]>>> MONTH()
    7
    [Stellar]>>> MONTH(1502664380)
    7
    [Stellar]>>> WEEK_OF_MONTH(1502664380)
    3
    [Stellar]>>> DAY_OF_MONTH(1502664380)
    13
    [Stellar]>>> WEEK_OF_YEAR(1502664380)
    33
    [Stellar]>>> DAY_OF_WEEK(1502664380)
    1
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to