Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/692
  
    
    
    
    
    
    
    
    
    
*[metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java,
 line 41 at 
r1](https://reviewable.io:443/reviews/apache/metron/692#-KrQxEY26NFRZCW9pxUV-r1-41:-KrWFRZOTUTP31ovphsm:b-s1bb91)
 ([raw 
file](https://github.com/apache/metron/blob/186d53ec56ee72281e1ec2dc2de3cc265d4b73d5/metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java#L41)):*
    <details><summary><i>Previously, JonZeolla (JonZeolla) 
wrote…</i></summary><blockquote>
    
    We should handle inputs of length 1-9 as well.
    </blockquote></details>
    
    So, the 10/13 rule is pretty standard.  If we do this, then we know we are 
doing seconds->millis for current timestamps.
    
    for < 10, we don't know if it is millis or timestamps, at least that is my 
thinking.  adding a 0 up to 13 for those numbers is equally as bad as just 
leaving them no?
    
    ---
    
    
    *Comments from 
[Reviewable](https://reviewable.io:443/reviews/apache/metron/692)*
    <!-- Sent from Reviewable.io -->



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to