Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/727#discussion_r136438190
  
    --- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
 ---
    @@ -450,4 +454,40 @@ public Object apply(List<Object> strings) {
         }
       }
     
    +  @Stellar( name = "PARSE_JSON_STRING"
    +          , description = "Returns a JSON object for the specified JSON 
string"
    +          , params = {
    +            "str - the JSON String to convert, may be null"
    +          }
    +          , returns = "an Object containing the parsed JSON string"
    +  )
    +  public static class ParseJsonString extends BaseStellarFunction {
    +
    --- End diff --
    
    So we are just returning whatever we get back from Jackson to the caller.  
Meaning that they have to understand the content of the json in order to write 
the expression correctly.  This needs to be documented if it stays like this.
    
    I am not sure I like that.  Can you give the use cases or circumstances 
that where you imagine this being used?  What are the bounds?
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to