[GitHub] metron pull request #727: METRON-1146: Add ability to parse JSON string into...

[ottobackwards]

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/727#discussion_r137270218
  
    --- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
 ---
    @@ -450,4 +454,40 @@ public Object apply(List<Object> strings) {
         }
       }
     
    +  @Stellar( name = "PARSE_JSON_STRING"
    +          , description = "Returns a JSON object for the specified JSON 
string"
    +          , params = {
    +            "str - the JSON String to convert, may be null"
    +          }
    +          , returns = "an Object containing the parsed JSON string"
    +  )
    +  public static class ParseJsonString extends BaseStellarFunction {
    +
    --- End diff --
    
    I think it will make more sense to authors, and have less of a surprise 
factor.
    
    - you need to understand your data
    - use the right function
    - get good error checking and verification


---