GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/757
METRON-938: "service metron-rest start <password>" does not work on CentOS
7.
## Contributor Comments
Moved things from an init script to Ambari, since we manage pretty much
everything through Ambari anyway. Hive does something similar. Now, the
password comes from Ambari and we're independent of the `service` command and
underlying CentOS management in this realm.
A couple properties are pushed to Ambari to make this easier. Notably,
it's a pain in the butt (and maybe not possible at all), to get the version of
our Metron install from interrogating Ambari. As such, it's added an invisible
read-only property. This probably has to be revisited when we support upgrades
(in order to make sure that the version increments appropriately). If this is
objectionable, we may want to just hard code it and replace it when we do the
overall release increments like we do the other instances.
As a sidenote, it would be really nice to have a version/profile/whatever
of full-dev available on CentOS 7.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/metron METRON-938
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/757.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #757
----
commit 5701db6d9338b4a32f358aa5ec081e11b7618cdb
Author: justinjleet <[email protected]>
Date: 2017-09-13T00:06:19Z
WIP
commit 109591348fda5f7728721948ed9521453c0bbabb
Author: justinjleet <[email protected]>
Date: 2017-09-13T19:52:40Z
mostly working
commit cc7be848d3fb7b3285f288ff8283f77bc1e8f06d
Author: justinjleet <[email protected]>
Date: 2017-09-13T23:04:42Z
taking out password argument to avoid exposing in ps
commit b7387ee23a6a7bcb5214d1a8efcb2d69807243e5
Author: justinjleet <[email protected]>
Date: 2017-09-13T23:26:49Z
Fixing restart, updating documentation, and removing extraneous fields from
template
commit 7a998f6116891a3b2c4ca40d849ac46a0d0fa48a
Author: justinjleet <[email protected]>
Date: 2017-09-14T15:20:44Z
removing extra comments
----
---
