Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/757#discussion_r139942579
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/rest_commands.py
---
@@ -58,17 +74,94 @@ def init_kafka_acls(self):
def start_rest_application(self):
Logger.info('Starting REST application')
- command = format("service metron-rest start
{metron_jdbc_password!p}")
- Execute(command)
+
+ # Build the spring options
+ # the vagrant Spring profile provides configuration values,
otherwise configuration is provided by rest_application.yml
+ metron_spring_options = format(" --server.port={metron_rest_port}")
--- End diff --
Ignore the things I say, it would have helped if I'd done stuff right. PR
is updated to primarily run from a script, that's largely a renamed and
slightly modified metron-rest (rename is to metron-rest.sh). Need to update
docs to reflect it.
I also killed the metron version variable by doing some shell globbing. If
you have multiple metron-rest jars in the lib directory it could be
problematic, but I don't think it's unreasonable to not add random crap to the
dirs.
---
