Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/760#discussion_r139170122
  
    --- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
 ---
    @@ -226,6 +276,44 @@ public static void uploadConfigsToZookeeper(String 
rootFilePath, CuratorFramewor
         uploadConfigsToZookeeper(rootFilePath, rootFilePath, rootFilePath, 
rootFilePath, rootFilePath, client);
       }
     
    +  public static void uploadConfigsToZookeeper(String rootFilePath, 
CuratorFramework client,
    --- End diff --
    
    Can you add Javadocs to these methods?


---

Reply via email to