Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/760#discussion_r139160248
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
 ---
    @@ -55,14 +56,14 @@ def is_kafka_acl_configured(self):
         def set_kafka_configured(self):
             Logger.info("Setting Kafka Configured to True")
             File(self.__params.enrichment_kafka_configured_flag_file,
    -             content="",
    +             content="This file created on: " + 
datetime.now().strftime('%Y-%m-%d %H:%M:%S'),
    --- End diff --
    
    Mostly thinking out loud about a follow on, would it be worth it to just 
pull these file creations (and probably a variant of the Logger statement) into 
a `createConfiguredFlagFile` function in the common area, and just pass it the 
flag file?  They all have the same content, owner, and perms, right?


---

Reply via email to