Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/799#discussion_r144854901
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
 ---
    @@ -232,3 +241,48 @@ def set_hbase_acls(self):
     
             Logger.info("Done setting HBase ACLs")
             self.set_hbase_acl_configured()
    +
    +    def service_check(self, env):
    +        """
    +        Performs a service check for Enrichment.
    +        :param env: Environment
    +        """
    +        Logger.info("Checking for Geo database")
    +        metron_service.check_hdfs_file_exists(self.__params, 
self.__params.geoip_hdfs_dir + "/GeoLite2-City.mmdb.gz")
    --- End diff --
    
    You know, honestly, the better approach here, unfortunately, is to pull the 
config from the global config and ensure that the file exists.  What if the 
user renames the GeoLite database to something other than 
`GeoLite2-City.mmdb.gz`?  Can we make that a follow-on JIRA at least?


---

Reply via email to