Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/799#discussion_r144858358
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
 ---
    @@ -232,3 +241,48 @@ def set_hbase_acls(self):
     
             Logger.info("Done setting HBase ACLs")
             self.set_hbase_acl_configured()
    +
    +    def service_check(self, env):
    +        """
    +        Performs a service check for Enrichment.
    +        :param env: Environment
    +        """
    +        Logger.info("Checking for Geo database")
    +        metron_service.check_hdfs_file_exists(self.__params, 
self.__params.geoip_hdfs_dir + "/GeoLite2-City.mmdb.gz")
    --- End diff --
    
    I agree.  I don't like hard-coding "GeoLite2-City.mmdb.gz" here.  I just 
didn't see anywhere in the Mpack where we had that value parameterized already.
    
    Where in the code do we have it parameterized?  I'd love to fix this.
    



---

Reply via email to