Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/795#discussion_r146017385
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/IndexingUpdater.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.common.zookeeper.configurations;
+
+import org.apache.curator.framework.CuratorFramework;
+import org.apache.metron.common.configuration.ConfigurationType;
+import org.apache.metron.common.configuration.ConfigurationsUtils;
+import org.apache.metron.common.configuration.IndexingConfigurations;
+import org.apache.zookeeper.KeeperException;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.function.Supplier;
+
+public class IndexingUpdater extends
ConfigurationsUpdater<IndexingConfigurations> {
+ public IndexingUpdater(Reloadable reloadable,
Supplier<IndexingConfigurations> configSupplier) {
+ super(reloadable, configSupplier);
+ }
+
+ @Override
+ public Class<IndexingConfigurations> getConfigurationClass() {
+ return IndexingConfigurations.class;
+ }
+
+ @Override
+ public void forceUpdate(CuratorFramework client) {
+ try {
+
ConfigurationsUtils.updateSensorIndexingConfigsFromZookeeper(getConfigurations(),
client);
+ }
+ catch (KeeperException.NoNodeException nne) {
+ LOG.warn("No current indexing configs in zookeeper, but the cache
should load lazily...");
+ }
+ catch (Exception e) {
+ LOG.warn("Unable to load indexing configs from zookeeper, but the
cache should load lazily...", e);
+ }
+ }
+
+ @Override
+ public IndexingConfigurations defaultConfigurations() {
+ return new IndexingConfigurations();
+ }
+
+ @Override
+ public void delete(CuratorFramework client, String path, byte[] data)
throws IOException {
+ String name = path.substring(path.lastIndexOf("/") + 1);
+ if (path.startsWith(ConfigurationType.INDEXING.getZookeeperRoot())) {
--- End diff --
All of the `ConfigurationUpdater`s perform similar logic for `delete` and
`update`. Would it make sense to pull this logic up so that it can be shared?
---
