Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/795#discussion_r146020428
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/ProfilerUpdater.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.common.zookeeper.configurations;
+
+import static
org.apache.metron.common.configuration.ConfigurationType.PROFILER;
+import org.apache.curator.framework.CuratorFramework;
+import org.apache.metron.common.configuration.ConfigurationType;
+import org.apache.metron.common.configuration.ConfigurationsUtils;
+import org.apache.metron.common.configuration.profiler.ProfilerConfig;
+import
org.apache.metron.common.configuration.profiler.ProfilerConfigurations;
+import org.apache.metron.common.utils.JSONUtils;
+import org.apache.zookeeper.KeeperException;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.function.Supplier;
+
+public class ProfilerUpdater extends
ConfigurationsUpdater<ProfilerConfigurations> {
+ public ProfilerUpdater(Reloadable reloadable,
Supplier<ProfilerConfigurations> configSupplier) {
+ super(reloadable, configSupplier);
+ }
+
+ @Override
+ public Class<ProfilerConfigurations> getConfigurationClass() {
+ return ProfilerConfigurations.class;
+ }
+
+ private ProfilerConfig readFromZookeeper(CuratorFramework client) throws
Exception {
+ byte[] raw = client.getData().forPath(PROFILER.getZookeeperRoot());
+ return JSONUtils.INSTANCE.load(new ByteArrayInputStream(raw),
ProfilerConfig.class);
+ }
+
+ @Override
+ public void forceUpdate(CuratorFramework client) {
+ try {
+ ConfigurationsUtils.updateConfigsFromZookeeper(getConfigurations(),
client);
+ }
+ catch (KeeperException.NoNodeException nne) {
+ LOG.warn("No current global configs in zookeeper, but the cache
should load lazily...");
+ }
+ catch(Exception e) {
+ LOG.warn("Unable to load global configs from zookeeper, but the
cache should load lazily...", e);
+ }
+ try {
+ ProfilerConfig config = readFromZookeeper(client);
+ if(config != null) {
+ getConfigurations().updateProfilerConfig(config);
+ }
--- End diff --
This is because the Profiler doesn't have a call in ConfigurationsUtils,
unlike the rest of our fundamental types (e.g.
`update{Parser,Enrichment,etc}ConfigsFromZookeeper`). When calling those, an
update to the global config is called and then the configs are updated. This
is done here and it's why it's a bit different. I thought about moving this
abstraction to `ConfigurationsUtils`, but I felt that class was already so
onerous and needed to be fundamentally refactored so deeply that I didn't have
the heart to create a `updateProfilerConfigsFromZookeeper` method.
---
