Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/831#discussion_r150316808
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py
 ---
    @@ -162,34 +164,77 @@ def start_indexing_topology(self, env):
                                           self.__params.metron_principal_name,
                                           
execute_user=self.__params.metron_user)
     
    -            start_cmd_template = 
"""{0}/bin/start_elasticsearch_topology.sh \
    -                                        -s {1} \
    -                                        -z {2}"""
    -            start_cmd = 
start_cmd_template.format(self.__params.metron_home,
    -                                                  self.__indexing_topology,
    -                                                  
self.__params.zookeeper_quorum)
    +            start_cmd_template = """{0}/bin/start_hdfs_topology.sh"""
    +            start_cmd = 
start_cmd_template.format(self.__params.metron_home)
                 Execute(start_cmd, user=self.__params.metron_user, tries=3, 
try_sleep=5, logoutput=True)
     
             else:
    -            Logger.info('Indexing topology already running')
    +            Logger.info('Batch Indexing topology already running')
     
    -        Logger.info('Finished starting indexing topology')
    +        Logger.info('Finished starting batch indexing topology')
     
    -    def stop_indexing_topology(self, env):
    -        Logger.info('Stopping ' + self.__indexing_topology)
    +    def start_random_access_indexing_topology(self, env):
    +        Logger.info('Starting ' + self.__random_access_indexing_topology)
    --- End diff --
    
    I like this a lot.  I would like to see the indexing be like the parses, 
where you start with a name parameter.  I think the flux files make it 
difficult though.  I would be +1 exploring this approach though, maybe a 
feature branch?


---

Reply via email to