Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/831#discussion_r151189543
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-indexing-env.xml
 ---
    @@ -73,18 +98,31 @@
             <display-name>Indexing Update Column Family</display-name>
         </property>
         <property>
    -        <name>indexing_workers</name>
    +        <name>ra_indexing_workers</name>
    +        <description>Number of Indexing Topology Workers</description>
    --- End diff --
    
    That sounds good.  Which one would you guys prefer:
    * display names in the mpack of "Elasticsearch" and "HDFS"
    * variable prefixes of `es` and `hdfs`
    
    I think I'd prefer the first as I really have been trying to set us up to a 
world where we can make things pluggable (this is the first baby step).


---

Reply via email to