Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/858#discussion_r156183048
  
    --- Diff: 
metron-interface/metron-alerts/e2e/alerts-list/configure-table/configure-table.e2e-spec.ts
 ---
    @@ -58,26 +58,26 @@ describe('metron-alerts configure table', function() {
         page.saveConfigureColumns();
       });
     
    -  it('should rename columns from table configuration', () => {
    -    page.clearLocalStorage();
    -    page.navigateTo();
    -
    -    page.clickConfigureTable();
    -    page.renameColumn('enrichments:geo:ip_dst_addr:country', 'Country');
    -    page.saveConfigureColumns();
    -
    -    page.clickTableText('FR');
    -    expect(page.getSearchText()).toEqual('Country:FR');
    -    expect(page.getChangesAlertTableTitle('Alerts (169)')).toEqual('Alerts 
(25)');
    -    page.clickClearSearch();
    -
    -    expect(page.getChangesAlertTableTitle('Alerts (25)')).toEqual('Alerts 
(169)');
    -    page.setSearchText('Country:FR');
    -    expect(page.getChangesAlertTableTitle('Alerts (169)')).toEqual('Alerts 
(25)');
    -    page.clickClearSearch();
    -
    -    expect(page.getTableColumnNames()).toContain('Country', 'for renamed 
column names for alert list table');
    -
    -  });
    +  // it('should rename columns from table configuration', () => {
    --- End diff --
    
    Same here


---

Reply via email to