Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/853#discussion_r168816712 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java --- @@ -101,16 +99,16 @@ public void setSort(List<SortField> sort) { this.sort = sort; } - public Optional<List<String>> getFields() { - return fields == null || fields.size() == 0 ? Optional.empty() : Optional.of(fields); + public List<String> getFields() { + return fields; } public void setFields(List<String> fields) { this.fields = fields; } - public Optional<List<String>> getFacetFields() { - return facetFields == null || facetFields.size() == 0 ? Optional.empty() : Optional.of(facetFields); + public List<String> getFacetFields() { + return facetFields; --- End diff -- Because null and an empty array mean 2 different things. See point 6 here: https://github.com/apache/metron/pull/853#issuecomment-356350839.
---