Yeah, we need to update the release process instructions. It should actually be step 10 shouldn't it? We want to keep the rc tag as-is because it may get rejected/cancelled, and update the final tag as the release. I already need to overhaul that page to reflect the addition of the RC creation script, so I can also update it.
I didn't remember there was a specific reason for the git tagging, so I just followed the convention we used for the main repo, which is why we have this problem. The release candidate script also needs to be updated (because it needs to know the proper prior tag to pull). It's not hard to do, but we'll need to open a Jira and update that portion of the script. It's pretty easy to do, it's just the portion here <https://github.com/apache/metron/blob/master/dev-utilities/release-utils/prepare-release-candidate#L245> . On Wed, Oct 10, 2018 at 5:09 PM Michael Miklavcic < michael.miklav...@gmail.com> wrote: > +1 to all of that from me, Jon. Thanks for taking care of this. > > On Wed, Oct 10, 2018 at 2:34 PM zeo...@gmail.com <zeo...@gmail.com> wrote: > > > I wonder if we should also update the > > https://cwiki.apache.org/confluence/display/METRON/Release+Process > > instructions > > to include tagging for the bro plugin, or if we were going to split out > the > > release processes? I'd be happy to update the instructions (Step 8) if > > that's the right place for now and I didn't miss a new place for the > plugin > > release instructions. > > > > Jon > > > > On Wed, Oct 10, 2018 at 4:31 PM zeo...@gmail.com <zeo...@gmail.com> > wrote: > > > > > So I was poking around on the plugin today and noticed that we have > > > a apache-metron-bro-plugin-kafka_0.2.0-release and > > apache-metron-bro-plugin-kafka_0.2.0-rc1 > > > tag, but no 0.2 (which is what bro-pkg would point to). Anybody have > any > > > concerns if I push the 0.2 tag as discussed above? Then we could > update > > > the bro package manager, and finally update what the apache/metron > > full-dev > > > environment(s) point to (0.2 as opposed to 0.1). Thanks, > > > > > > Jon > > > > > > On Mon, May 28, 2018 at 8:41 AM zeo...@gmail.com <zeo...@gmail.com> > > wrote: > > > > > >> I did a bit of poking around and I don't believe we ever formally > wrote > > >> that down. The last release happened as a combination of actions from > > >> mattf and myself (mostly mattf). > > >> > > >> The plugin has two new commits since the last release (1 bugfix 1 > > >> feature) - if we want to couple version 0.2 of the plugin with a > metron > > >> 0.5.0 release we would need to make a 0.2 tag against HEAD of the > plugin > > >> repo, then increment the version in the ansible playbooks here > > >> < > > > https://github.com/apache/metron/blob/master/metron-deployment/ansible/roles/bro/vars/main.yml#L30 > > > > > >> . > > >> > > >> Or, if we just want to make a plugin release without changing > > >> apache/metron, we could just make a 0.2 tag in the plugin repo, and > then > > >> release it in a more disjointed way. I know that's not super helpful > > since > > >> I don't have documentation for doing an apache release of the plugin > > other > > >> than hacking something together based on what's out there for > > apache/metron. > > >> > > >> Reference conversations: > > >> - > > >> > > > https://lists.apache.org/thread.html/2606166bd5e864f1b56db302099c9a8042cdadec8fa2692fef49493f@%3Cdev.metron.apache.org%3E > > >> - > > >> > > > https://lists.apache.org/thread.html/3aecbadbf3353e98c03ca4b680fcd998d0cd2bf5a4319238dd85ae75@%3Cdev.metron.apache.org%3E > > >> > > >> Jon > > >> > > >> On Fri, May 25, 2018 at 2:00 PM Justin Leet <justinjl...@gmail.com> > > >> wrote: > > >> > > >>> At the risk of exposing my ignorance, do we have the bro plugin > release > > >>> process documented anywhere? We have a doc for the main release ( > > >>> https://cwiki.apache.org/confluence/display/METRON/Release+Process), > > >>> but I > > >>> haven't noticed one for the bro plugin. > > >>> > > >>> For the current RC, it's not included and it wasn't pushed for (it > has > > >>> less > > >>> changes for obvious reasons). However, we should be making sure to > > >>> validate if its necessary to release and having the process > documented. > > >>> > > >>> Justin > > >>> > > >> -- > > >> > > >> Jon > > >> > > > -- > > > > > > Jon > > > > > -- > > > > Jon > > >
