This pull request is a little atypical: The assertion of this pull request is only to bring Metron up-to-date with the tip of the code that CISCO published. https://github.com/OpenSOC/opensoc-streaming
There is no assertion that it is ideal code. A as Owen suggested a few comments back, my hope is that a reviewer will confirm that the pull request really does match the tip of https://github.com/OpenSOC/opensoc-streaming, Once we get it merged we can start fixing the bugs and beating into shape as deployable code. After stability, we can start adding features, which is what a lot of people really want to do. (Alternatively, someone could object to the premise that we want Metron to baseline at the tip of Cisco code. Then we would have a discussion on where to start the Metron project) On Wed, Dec 16, 2015 at 2:59 PM, james-sirota <[email protected]> wrote: > Github user james-sirota commented on a diff in the pull request: > > https://github.com/apache/incubator-metron/pull/2#discussion_r47825924 > > --- Diff: > opensoc-streaming/OpenSOC-Alerts/src/main/java/com/opensoc/alerts/TelemetryAlertsBolt.java > --- > @@ -185,10 +184,10 @@ public void execute(Tuple tuple) { > JSONArray uuid_list = new JSONArray(); > > if (alerts_list == null || alerts_list.isEmpty()) { > - LOG.trace("[OpenSOC] No alerts detected > in: " > + System.out.println("[OpenSOC] No alerts > detected in: " > --- End diff -- > > I think this is a piece of debugging that someone forgot to comment > out. We can ignore this > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- >
