Github user james-sirota commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/2#discussion_r47837646
  
    --- Diff: 
opensoc-streaming/OpenSOC-Alerts/src/main/java/com/opensoc/alerts/TelemetryAlertsBolt.java
 ---
    @@ -185,10 +184,10 @@ public void execute(Tuple tuple) {
                        JSONArray uuid_list = new JSONArray();
     
                        if (alerts_list == null || alerts_list.isEmpty()) {
    -                           LOG.trace("[OpenSOC] No alerts detected in: "
    +                           System.out.println("[OpenSOC] No alerts 
detected in: "
    --- End diff --
    
    I think it's ok to have system.outs in the runners that launch the 
topology, but it shouldn't exist in the bolts themselves. you are correct. we 
should change it back to log.trace


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to