Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58237558
--- Diff:
metron-streaming/Metron-DataLoads/src/main/java/org/apache/metron/dataloads/hbase/mr/PrunerMapper.java
---
@@ -48,7 +48,7 @@ public void setup(Context context) throws IOException
}
try {
tracker =
AccessTrackerUtil.INSTANCE.loadAll(AccessTrackerUtil.INSTANCE.loadAll(table,
atCF, atName, timestamp));
- } catch (Exception e) {
+ } catch (Throwable e) {
--- End diff --
This is just a style thing. It's going to throw a runtime exception
regardless and kill the task, but I wanted it to be clear in the logs that
it was due to not bing able to load the access tracker stuff (as opposed to
an OOM exception).
On Fri, Apr 1, 2016 at 1:18 PM, David Lyle <[email protected]> wrote:
> In
>
metron-streaming/Metron-DataLoads/src/main/java/org/apache/metron/dataloads/hbase/mr/PrunerMapper.java
> <https://github.com/apache/incubator-metron/pull/66#discussion_r58236854>:
>
> > @@ -48,7 +48,7 @@ public void setup(Context context) throws IOException
> > }
> > try {
> > tracker =
AccessTrackerUtil.INSTANCE.loadAll(AccessTrackerUtil.INSTANCE.loadAll(table,
atCF, atName, timestamp));
> > - } catch (Exception e) {
> > + } catch (Throwable e) {
>
> Was this changed to deliberately catch subclasses of Error?
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/incubator-metron/pull/66/files/b4fc71e0a18ba9f2b897c3b01e16093903ed100a#r58236854>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
