Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58375098
--- Diff:
metron-streaming/Metron-Common/src/test/java/org/apache/metron/enrichment/EnrichmentConfigTest.java
---
@@ -0,0 +1,253 @@
+package org.apache.metron.enrichment;
+
+import org.apache.metron.Constants;
+import org.apache.metron.domain.SourceConfig;
+import org.apache.metron.utils.JSONUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class EnrichmentConfigTest {
+ @Test
+ public void testThreatIntel() throws Exception {
+ /*
+ {
+ "index": "bro",
--- End diff --
Normally I'd agree, but those comments are there because multiline strings
in java are lacking, so if changes to the JSON structure happen, the changes
generally happen to the comment and then the string is replaced, letting the
IDE handle escaping quotes. One thing that we could consider is incorporating
something like https://github.com/benelog/multiline, which i've seen in other
projects for these kinds of situations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
