Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/282#discussion_r81008117
--- Diff: metron-deployment/roles/mysql_server/tasks/geoip.yml ---
@@ -15,12 +15,21 @@
# limitations under the License.
#
---
-- name: Download GeoIP databases
+- name: Download GeoIP databases from specified URL
unarchive:
- src:
http://geolite.maxmind.com/download/geoip/database/GeoLiteCity_CSV/GeoLiteCity-latest.tar.xz
+ src: "{{ geodata_file }}"
dest: /tmp/geoip
copy: no
creates: /tmp/geoip/*/GeoLiteCity-Blocks.csv
+ when: '"{{ geodata_file }}".find("http://";) != -1'
--- End diff --
A better way to do this check might be the following. This approach is a
little simpler and doesn't preclude the use of FTP or HTTPS.
```
when: geodata_file is defined
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
