Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/282#discussion_r81011621
--- Diff: metron-deployment/roles/mysql_server/tasks/geoip.yml ---
@@ -15,12 +15,21 @@
# limitations under the License.
#
---
-- name: Download GeoIP databases
+- name: Download GeoIP databases from specified URL
unarchive:
- src:
http://geolite.maxmind.com/download/geoip/database/GeoLiteCity_CSV/GeoLiteCity-latest.tar.xz
+ src: "{{ geodata_file }}"
dest: /tmp/geoip
copy: no
creates: /tmp/geoip/*/GeoLiteCity-Blocks.csv
+ when: '"{{ geodata_file }}".find("http://";) != -1'
--- End diff --
With your original approach, you can set `geodata: 'skip'` (anything other
than http://) and it completely skips loading the geodata. That is a nice
option to have.
I think this still works with my suggested approach if you set the property
like this; `geodata: ~`. Warning: I haven't tested this and Ansible makes
these things a little painful.
However it gets done, I think it would be nice to...
* Use HTTPS, HTTP, and FTP URLs
* Not load any geodata, if so desired
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
