Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/286#discussion_r81339191
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/hdfs/HdfsWriter.java
---
@@ -69,14 +66,19 @@ public void init(Map stormConfig, WriterConfiguration
configurations) {
@Override
- public void write(String sourceType
+ public BulkWriterResponse write(String sourceType
, WriterConfiguration configurations
, Iterable<Tuple> tuples
, List<JSONObject> messages
) throws Exception
{
SourceHandler handler = getSourceHandler(sourceType);
handler.handle(messages);
+
+ // HDFS SourceHanlder manages writing and rotating files. Will throw
its own Exceptions.
--- End diff --
typo on `SourceHandler`.
Also, if the `SourceHandler` manages writing and will throw exceptions, do
we want to catch the exception, add the tuples as errors to the response and
rethrow?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
